Skip to content

Import rlang and use unqualified form for rlang functions #3242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yutannihilation
Copy link
Member

Fixes #3195

Since it's common practice to import whole rlang package, ggplot2 should follow it. This PR adds import(rlang) to NAMESPACE and removes all rlang::.

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yutannihilation
Copy link
Member Author

Thanks.

@yutannihilation yutannihilation merged commit 9209970 into tidyverse:master Apr 23, 2019
@yutannihilation yutannihilation deleted the refactor/import-rlang branch April 23, 2019 22:47
@paleolimbot paleolimbot mentioned this pull request May 6, 2019
@lock
Copy link

lock bot commented Oct 20, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@import rlang?
2 participants