Better error message when geom_boxplot() gets group data with more than 1 row

[paleolimbot]

This is a PR to fix #3316, where group data with more than 1 row in GeomBoxplot$draw_layer() was causing an error that was difficult to diagnose. This may occur when using geom_boxplot(stat = "identity"), and is likely to occur if a user wants to draw several boxplots at specific locations on a plot in a boxplot/scatter mashup situation.

library(ggplot2)
ggplot(
  data.frame(x = "one value", y = 3, value = 4:6),
  aes(x, ymin = 0, lower = 1, middle = y, upper = value, ymax = 10)
) + 
  geom_boxplot(stat = "identity", position = "identity")
#> Error: Elements must equal the number of rows or 1

[clauswilke]

LGTM, except the one minor formatting issue I point out.

[clauswilke]

I think there should be a space before and after the = sign.

[clauswilke]

Sorry, one more issue: Could you amend the latest commit message so it includes "Closes #3316" or "Fixes #3316"? This will allow github to automatically link the commit to the bug and it will close the bug upon merge.

Example: cfd4962

[codecov]

Codecov Report

Merging #3321 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3321   +/-   ##
=======================================
  Coverage   78.94%   78.94%           
=======================================
  Files         171      171           
  Lines        6692     6692           
=======================================
  Hits         5283     5283           
  Misses       1409     1409

Impacted Files	Coverage Δ
R/geom-boxplot.r	92.59% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b69172...8ee5f88. Read the comment docs.

[codecov]

Codecov Report

Merging #3321 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3321   +/-   ##
=======================================
  Coverage   78.94%   78.94%           
=======================================
  Files         171      171           
  Lines        6692     6692           
=======================================
  Hits         5283     5283           
  Misses       1409     1409

Impacted Files	Coverage Δ
R/geom-boxplot.r	92.59% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b69172...8ee5f88. Read the comment docs.

[clauswilke]

Did the force push undo the commit that fixed the spacing?

Also, one issue that may or may not be related: I'm seeing a lot of github activity with strange time stamps (events occurring in the future, or in the wrong order). Is your machine set up to use local time? It's generally best to set up the machine time to UTC and then tell the machine what time zone you're in, rather than running it on local time.

[paleolimbot]

It did! I googled how to amend a commit message and it backfired. Will fix.

[paleolimbot]

I'm glad you're seeing the datetime issue as well...I thought I was going nuts. I think it happens with all my github activity from my laptop, which is why some stuff is out of order. Hopefully tomorrow I will be back to living in the present.

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/