Skip to content

Adds american spelling to scale_colour_date/datetime() #3510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2019

Conversation

eliocamp
Copy link
Contributor

This adds missing alternative spelling to scale_colour_date() and scale_colour_datetime().

@yutannihilation
Copy link
Member

Good catch! Could you add scale_color_ordinal?

library(ggplot2)

scales_color <- ls(envir = as.environment("package:ggplot2"), pattern = "scale_color")
scales_colour <- ls(envir = as.environment("package:ggplot2"), pattern = "scale_colour")

setdiff(scales_colour, gsub("color", "colour", scales_color))
#> [1] "scale_colour_date"     "scale_colour_datetime" "scale_colour_ordinal"

Created on 2019-08-30 by the reprex package (v0.3.0)

@eliocamp
Copy link
Contributor Author

Yep, there it is. 🇺🇸️

@yutannihilation yutannihilation merged commit dcb510e into tidyverse:master Aug 30, 2019
@yutannihilation
Copy link
Member

Thanks!

@lock
Copy link

lock bot commented Feb 28, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants