Suppress guide for NULL breaks in non-position scales (Fixed #579).

[kohske]

No description provided.

[wch]

Thanks - does this pass all tests and visual tests?

Also it should be 'suppressed', not 'surpressed'.

[kohske]

@wch passes all unit test. Which version of vtest should I use, and which commit shoud the vtest do against?

All vtest are passed. I mean vdiff in vtest.

[wch]

You should use the latest version of vtest from github. I think you should test it against ggplot2-0.9.1 (but I'm not 100% sure).

You can also try running vdiffstat('recent') or vdiff_webpage('recent'), which should compare it against a somewhat newer commit (although that commit has the same resultset as 0.9.1).

[kohske]

@wch looks ok for visual comparison between the latest commit and tag 0.9.1.

[wch]

@kohske Thanks for running tests.

I have a question about the warnings: Does it really need a warning when users do breaks=NULL? For positional scales (x and y), breaks=NULL just means that nothing shows up on the guide (the axis ticks), and there's no warning.

In other words, why is it valid to use breaks=NULL for x and y, but invalid for colour, fill, etc?

[kohske]

@wch I think that non-positional guide without breaks is meaningless while positional guide without breaks is used in somewhere What do you think?

At least, legend guide cannot be drawn if there is no breaks.

[wch]

I think it makes sense for a non-positional guide to be suppressed when breaks=NULL, but I don't think a warning is necessary. I guess we can see what Hadley thinks.

[kohske]

Ok, I will wait @hadley 's response.

[hadley]

I vote for no warning.

[wch]

I took out the warnings and merged into master (2e7015c).

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/