Make .configureOutput() create copy of settings instead of in-place change #2350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowspawn
added
the
semver: major
|
Could go in a minor version since a bug fix, but thinking hold until we do a release to drop node 18 since will break anyone who was inadvertently relying on previous behaviour. |
shadowspawn
changed the title
abetomo
approved these changes
Mar 26, 2025
shadowspawn
added
the
pending release
galaxycores
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Modifying command using
.configureOutput()modifies other commands sharing same settings.Fixes: #2342
Solution
Make a copy of settings instead of modifying in place.
ChangeLog
.configureOutput()now makes copy of settings instead of modifying in-place, fixing side-effects