-
-
Notifications
You must be signed in to change notification settings - Fork 102
feat : update platforms list and the --platform option #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : update platforms list and the --platform option #246
Conversation
tldr-pages#236 add aliases to OS_DIRECTORY variable
update supported platforms in the parser --platform add_argument method
I'm sorry I didn't know how to continue the work that was done on #236 so I directly made a new PR. |
It's nice to see that the workflow is checking my code so I can fix it. Good feature ! |
Co-authored-by: spageektti <[email protected]>
Co-authored-by: spageektti <[email protected]>
I don't understand the lint codebase message :
I opened the raw file in a text editor and did not see the supposed added characters on lines 522 and 524. |
add multi line support
Ok I saw how to divide the 2 longer lines to ones that's fit with the 88 maximum length standard. |
Now there's a e131 lint error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but havent tested locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for your contribution. Tested the changes locally, this PR is GTG.
This PR may close #234, #235 and #236.
Be aware that this pull request is based only on code analysis and has not been tested!
I would be really pleased if someone could test this PR and see if it works.