Skip to content

feat : update platforms list and the --platform option #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 27, 2024

Conversation

patricedenis
Copy link
Contributor

This PR may close #234, #235 and #236.
Be aware that this pull request is based only on code analysis and has not been tested!
I would be really pleased if someone could test this PR and see if it works.

tldr-pages#236 
add aliases to OS_DIRECTORY variable
update supported platforms in the parser --platform add_argument method
@patricedenis
Copy link
Contributor Author

patricedenis commented Jun 26, 2024

I'm sorry I didn't know how to continue the work that was done on #236 so I directly made a new PR.

@kbdharun kbdharun self-assigned this Jun 26, 2024
@patricedenis
Copy link
Contributor Author

It's nice to see that the workflow is checking my code so I can fix it. Good feature !

@patricedenis
Copy link
Contributor Author

I don't understand the lint codebase message :

Run python3 -m flake8
./tldr.py:522:89: E501 line too long (106 > 88 characters)
./tldr.py:524:89: E501 line too long (116 > 88 characters)
Error: Process completed with exit code 1.

I opened the raw file in a text editor and did not see the supposed added characters on lines 522 and 524.

@patricedenis
Copy link
Contributor Author

I don't understand the lint codebase message :

Run python3 -m flake8
./tldr.py:522:89: E501 line too long (106 > 88 characters)
./tldr.py:524:89: E501 line too long (116 > 88 characters)
Error: Process completed with exit code 1.

I opened the raw file in a text editor and did not see the supposed added characters on lines 522 and 524.

Ok I saw how to divide the 2 longer lines to ones that's fit with the 88 maximum length standard.

@patricedenis
Copy link
Contributor Author

Now there's a e131 lint error.
it's again related to indentation.

Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but havent tested locally

Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution. Tested the changes locally, this PR is GTG.

@kbdharun kbdharun linked an issue Jun 27, 2024 that may be closed by this pull request
@kbdharun kbdharun changed the title feat : update platforms to --platform option feat : update platforms list and the --platform option Jun 27, 2024
@kbdharun kbdharun merged commit 5decc07 into tldr-pages:main Jun 27, 2024
8 checks passed
@kbdharun kbdharun added this to the 3.3.0 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BSDs are supported, but cannot be passed to the --platform option The macos alias for osx is not supported
3 participants