Add optional parameter literal to Pane.send_keys
#121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 79.49% 79.42% -0.07%
==========================================
Files 8 8
Lines 863 865 +2
==========================================
+ Hits 686 687 +1
- Misses 177 178 +1
Continue to review full report at Codecov.
|
|
@ritiek Can you rebase this (so the tests again?) |
|
Rebased. :) |
|
Seems the only error for this was a timeout? Can we rerun the test? |
|
Ok, they passed. |
|
@ritiek Can we add a test for this? |
|
@ritiek merged! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88.
This PR adds an optional parameter
literal=FalsetoPane.send_keyswhich does not send keys to a tmux pane literally by default. Whenliteralis set toTrue, it prefixes thesend-keyscommand with-lparameter which allows sending keys literally.