Handle next-X.Y versions #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmuxp currently crashes when used with tmux next-2.9 (the latest Homebrew release). ``` TypeError: '<' not supported between instances of 'str' and 'int' ``` This patch avoids the error by making `get_version()` strip the "next-" part of the version. closes tmux-python/tmuxp#449
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
=======================================
Coverage 79.49% 79.49%
=======================================
Files 8 8
Lines 863 863
=======================================
Hits 686 686
Misses 177 177
Continue to review full report at Codecov.
|
|
@sloria Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmuxp currently crashes when used with
tmux next-2.9 (the latest Homebrew release).
This patch avoids the error by making
get_version()strip the "next-" part of the version.
closes tmux-python/tmuxp#449