-
Notifications
You must be signed in to change notification settings - Fork 109
Adding type hints to class methods returning self and child #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 87.90% 87.99% +0.09%
==========================================
Files 15 15
Lines 1496 1499 +3
==========================================
+ Hits 1315 1319 +4
+ Misses 181 180 -1
Continue to review full report at Codecov.
|
@tony I appreciate the invitation! I don't know if I'll have availability to collaborate simultaneous on Saturday but I'm happy to help gradually add type hints when I can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SessionDict
,WindowDict
, andPaneDict
type aliases tocommon.py
for _list methodsself
and collections of children