Skip to content

Updating readability and technical info #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

OdinsHat
Copy link

I took you up on the offer to help on the project. I've done like the commit message says. Updated based on latest technical features. Readability and tidy up. Let me know if you want anything.

Added some extra information and made some improvements in grammar, structure and readability. I consider this the beginning of a general tidy up of the docs and manual section taking hints from tmuxinator and teamocli
Comparisons were given better structure and titles with updated information on features. Ambiguous titles have been made clearer
@codecov-io
Copy link

codecov-io commented Feb 25, 2019

Codecov Report

Merging #478 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
- Coverage   75.06%   74.93%   -0.13%     
==========================================
  Files           5        5              
  Lines         794      794              
  Branches      231      231              
==========================================
- Hits          596      595       -1     
  Misses        146      146              
- Partials       52       53       +1
Impacted Files Coverage Δ
tmuxp/workspacebuilder.py 90.9% <0%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4aa2e2...89239b4. Read the comment docs.

@tony
Copy link
Member

tony commented May 12, 2019

@OdinsHat Nice!

@tony
Copy link
Member

tony commented Aug 16, 2020

@OdinsHat Hi there, sorry about this! Can I get another rebase?

I just merged #623 which moves us to a poetry packaging setup and will runs the PR through GitHub actions.

@tony
Copy link
Member

tony commented Oct 25, 2020

@OdinsHat Can you please rebase this? I don't have permission to merge it due to conflicts

I'd like you to get credit for the PR itself (not only the commit)

I can also opt to cherry-pick the commits into master and resolve conflicts on my end - but I prefer you get full recognition in the pull request

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@OdinsHat
Copy link
Author

OdinsHat commented Jan 11, 2022 via email

@tony
Copy link
Member

tony commented Jan 29, 2022

@OdinsHat Hi there

Sorry if you are (or were) going through something, I hope things it better on the front.

The situation regarding this file has changed, it's in markdown now:
https://github.com/tmux-python/tmuxp/blob/master/docs/about.md

The diff is significant and it may be better to add the content again by starting from the most up to date about.md file.

I suggest this PR be closed and you make the changes in the new markdown format. I could solve the changes myself but I want to make sure you get credit for the PR

@tony
Copy link
Member

tony commented Feb 22, 2022

@OdinsHat To clean up PRs, since some time has passed since a response, I am closing this now but welcome you recreate the PR with our newest codebase

It's my fault for not getting to the PR fast enough, my bad on that.

If you do make a second PR, please email me and I will give you first priority to review

@tony tony closed this Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants