tests / fix: Fix v1.13.1 pane spacing issue #809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony
force-pushed
the
default-size-behavior
branch
from
3d1dad1 to
3f55292
Compare
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
==========================================
+ Coverage 75.20% 75.27% +0.06%
==========================================
Files 18 18
Lines 1432 1436 +4
Branches 336 336
==========================================
+ Hits 1077 1081 +4
Misses 267 267
Partials 88 88
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tony
force-pushed
the
default-size-behavior
branch
2 times, most recently
from
4a05ee5 to
f45a6f8
Compare
tony
force-pushed
the
default-size-behavior
branch
6 times, most recently
from
d220074 to
3f85af0
Compare
The comparison between height of main and other panes isn't true, we should update libtmux to support tmux's new formatters.
tony
force-pushed
the
default-size-behavior
branch
from
813f0a0 to
d703b65
Compare
tony
changed the title
tony
pushed a commit
that referenced
this pull request
Oct 1, 2022
This fixes a bug introduced in 2a4714e76b3a85b3391b05413f36623bcb1493f9 (#809) whereby the `start_directory` session config was no longer passed to the `new_session` method when building a session. This resulted in the session working directory is not being set correctly, so new windows/panes created in the session, would not start in the expected directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #800, #806
w/
entr(1):make watch_test test='tests/test_workspacebuilder.py::test_issue_800_default_size_many_windows -vvv -x -s'This may negate the fix in #793 (we may not be able to hard-code it)