Add for_await to process streams using a for loop #2
Conversation
| @@ -20,7 +20,7 @@ repository = "https://github.com/tokio-rs/async-stream" | |||
| readme = "README.md" | |||
|
|
|||
| [dependencies] | |||
| async-stream-impl = { version = "0.1.0" } | |||
| async-stream-impl = { version = "0.1.0", path = "../async-stream-impl" } | |||
There was a problem hiding this comment.
This must be revert before merging.
There was a problem hiding this comment.
It's fine to keep the path in here IMO.
| @@ -98,6 +98,42 @@ impl VisitMut for Scrub { | |||
| syn::visit_mut::visit_expr_mut(self, i); | |||
| self.is_xforming = prev; | |||
| } | |||
| syn::Expr::ForLoop(expr) => { | |||
| syn::visit_mut::visit_expr_for_loop_mut(self, expr); | |||
| // TODO: Should we allow other attributes? | |||
There was a problem hiding this comment.
What about just #[await]?
Also, since this is a macro anyway, we could potentially get more aggressive and transform:
for await foo in my_stream {
}There was a problem hiding this comment.
What about just
#[await]?
Sounds good to me.
for await foo in my_stream { }
I think syn doesn't support this syntax yet.
There was a problem hiding this comment.
(By the way, that TODO comment is about the current implementation confirming that the number of attributes is exactly one.)
There was a problem hiding this comment.
syn doesn't support it... but it may not be too hard to impl. You would have to manually walk the TokenStream and find for followed by await, transform that to #[await] for then run ^^.
That can be follow up work though...
No description provided.