AsciiChar::SOX should be AsciiChar::STX

[chrismooredev]

It seems that this crate's "Start of Text" member (ASCII '\x02') is mislabeled as SOX, whereas everything else on the web (including the linked-to Wikipedia page) references it as STX.

Since this would be a breaking change, I'm not sure how that would fit within the versioning, but I figured I'd report it anyway since I haven't seen any comments for this on the Issues/PRs for this repo.

[Zenithsiz]

It should be possible to rename the variant itself and add a deprecated const item to the impl with the previous variant (or just add STX as the const item).
Something as such:

impl AsciiChar {
    #[deprecated("Use `AsciiChar::STX`")]
    pub const SOX: Self = Self::STX;
}

This should be technically non-breaking, even in match arms, as AsciiChar is both PartialEq and Eq, but not sure if it could break elsewhere.

[tormol]

Renaming the variant breaks uses, both globs and explicit:

use ascii::AsciiChar::*; // Warning, unused.
let _ = SOX; // Error, did you mean SO?

use AsciiChar::SOX; // Error, did you mean SOH?

I couldn't find much about importing associated constants, other than a thread saying it's not supported and another thread explaining why. (the linked reference page doesn't make it clear at all).

I'll deprecate the variant, and then maybe rename with associated constant as fallback in a later version.

On the other hand I doubt which way it's done matters,
as I assume the only reason to glob-import will be to create a hardcoded &AsciiStr from &[AsciiChar] with printable characters. And useing select characters seems rather pointless.