Skip to content

add laravel 9 support #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2022
Merged

add laravel 9 support #29

merged 1 commit into from
Feb 13, 2022

Conversation

binotaliu
Copy link
Contributor

  • update composer.json to add Laravel 9
  • update github workflow to include Laravel 9
    • I need to add -W flag when installing livewire v2, otherwise there will be a conflict when running P8 - L9.* prefer-lowest
    • Livewire v1 only support Laravel version < 9, so I am excluding them for Laravel 9.

@aarondfrancis
Copy link
Contributor

This looks good to me! Thank you for doing this.

I do have one question about the testing matrix. Was there a reason you specifically chose livewire/livewire:^2.3.10 vs livewire/livewire:^2 like it was before?

I'm going to go ahead and merge since that's just a testing thing, but I'd be curious the reasoning behind it!

Thanks again.

@aarondfrancis aarondfrancis merged commit 6484d2b into torchlight-api:main Feb 13, 2022
@binotaliu
Copy link
Contributor Author

With -W I need to add --prefer-lowest on it. At first Composer tried to use livewire/livewire:v2.0.0 and then test failed.

Because LivewireTest is using
Livewire:: getPersistentMiddleware() and this method doesn't exist until v2.3.10.

@ralphjsmit
Copy link

@aarondfrancis Nice! Do you mind creating a release for this?😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants