Skip to content

Fix memory leak when using Laravel Octane #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2022
Merged

Fix memory leak when using Laravel Octane #41

merged 2 commits into from
Dec 9, 2022

Conversation

PhiloNL
Copy link
Contributor

@PhiloNL PhiloNL commented Dec 5, 2022

No description provided.

@PhiloNL
Copy link
Contributor Author

PhiloNL commented Dec 7, 2022

Alternatively, I could add this only when Octane is present:

if(class_exists(Laravel\Octane\Octane::class))
{
    BladeManager::clearBlocks();
}

aarondfrancis
aarondfrancis approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@aarondfrancis aarondfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough, thanks Philo!

@aarondfrancis aarondfrancis merged commit 3c7d670 into torchlight-api:main Dec 9, 2022
@PhiloNL PhiloNL deleted the patch-1 branch December 9, 2022 20:30
@PhiloNL
Copy link
Contributor Author

PhiloNL commented Dec 9, 2022

Thanks for merging! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarondfrancis aarondfrancis aarondfrancis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhiloNL @aarondfrancis