Bump tree sitter to 0.20.7 and expose highlights query in rust binding, take 3 #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
changed the title
ckipp01
reviewed
Jan 8, 2023
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "tree-sitter-scala", | |||
| "version": "0.19.1", | |||
| "version": "0.20.7", | |||
There was a problem hiding this comment.
Aren't these versions independent of each other? Meaning we bumped the one down below, but that shouldn't necessarily bump this also to 0.20.7 since this is our release version. Shouldn't this just be the semver version of tree-sitter-scala?
There was a problem hiding this comment.
Yea. The whole situation around versioning these grammar is murky to me. It's as-if grammars evolve at its own pace but the version is given at the timing of tree-sitter release?
It would also be convenient to know which grammar is expected to work with which tree-sitter version if there's some dependency, so the version might be functioning for the marker as well (like _2.12 suffix in Scala world).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resend of #100 minus a generated file.