Vararg class params and operator identifiers #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump dotty/scala library percentage
keynmol
commented
Jan 9, 2023
| (operator_identifier) | ||
| (generic_type | ||
| (type_identifier | ||
| (MISSING _plainid)) |
There was a problem hiding this comment.
I honestly don't know what this is.
Found tree-sitter/tree-sitter#1043 but not sure I understand both the issue and a way to fix it..
keynmol
commented
Jan 9, 2023
| @@ -1045,7 +1048,7 @@ module.exports = grammar({ | |||
|
|
|||
| wildcard: $ => '_', | |||
|
|
|||
| operator_identifier: $ => /[^\s\w\(\)\[\]\{\}'"`\.;,]+/, | |||
| operator_identifier: $ => /[!#%&*+-\/:<=>?@'^\|‘~]+/, | |||
There was a problem hiding this comment.
This is a more precise match, from https://docs.scala-lang.org/scala3/reference/syntax.html#
What it doesn't match is unicode characters from Sm, So, that's why in Predef this is an error:
@deprecated("Use `->` instead. If you still wish to display it as one character, consider using a font with programming ligatures such as Fira Code.", "2.13.0")
def →[B](y: B): (A, B) = ->(y)There was a problem hiding this comment.
I don't want to include all the characters from those character sets (thousands), so I think we can live with the limitation that ligatures will cause errors in the grammar
There was a problem hiding this comment.
People shouldn't be using ligatures anyways. ASCII or die.
eed3si9n
approved these changes
Jan 9, 2023
| SCALA_SCALA_LIBRARY_EXPECTED=95 | ||
| SCALA_SCALA_LIBRARY_EXPECTED=98 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does bring up the coverage, but unfortunately this handling of operator_identifier caused issues in prefix_expression tests.
I'm not sure how to fix the tests.
Another option would be to perhaps do
_identifier_like: $ => choice($.identifier, $.operator_identifier)but this takes us further away from what Scala syntax is like.