Skip to content

Export clauses #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Export clauses #125

merged 2 commits into from
Jan 10, 2023

Conversation

keynmol
Copy link
Collaborator

@keynmol keynmol commented Jan 10, 2023

Closes #76

breaking highlighting

For consistency, I renamed import_selectors to namespace_selectors to share them with exports.
This will break with old queries.

That said, given how sensitive they are (any node/keyword not present in the grammar causes highlighting to break), we've broken them a while back.

We'll sync them to nvim-treesitter soon.

@eed3si9n
Copy link
Collaborator

That said, given how sensitive they are (any node/keyword not present in the grammar causes highlighting to break), we've broken them a while back.

While implementing Scala 3 macros symbol literal got subsumed by quote expression, but I added back a dummy node called symbol_literal so it doesn't break the existing query. Adding unconnected node hopefully isn't too expensive.

Copy link
Collaborator

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 94bb82c into tree-sitter:master Jan 10, 2023
@keynmol keynmol deleted the export-clauses branch January 10, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export clauses
2 participants