Fixes instance_expression #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ------- Current grammar accepts expression immeidately after `new`, which is not correct, and doesn't work for Scala 3 syntax. Solution -------- This fixes it by actually using `$.template_body`. It does create a tricky conflict between `new A: <block>` construct and `new A: <type>`. To deal with that, we are using `prec.dynamic`.
eed3si9n
force-pushed
the
wip/instance
branch
from
d2d8336 to
77ea27e
Compare
keynmol
reviewed
Jan 12, 2023
| c = new D(e, f) | ||
| val a = new B | ||
| val c = new D(e, f) | ||
| val e = new E: |
There was a problem hiding this comment.
For posterity, can you also add an example of the quiet syntax new:
scala> trait Hello:
| def x: Int
|
// defined trait Hello
scala> val x: Hello = new:
| def x = 25
|
val x: Hello = anon$1@6bd92538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current grammar accepts expression immeidately after
new, which is not correct, and doesn't work for Scala 3 syntax.Solution
This fixes it by actually using
$.template_body. It does create a tricky conflict betweennew A: <block>construct andnew A: <type>.To deal with that, we are using
prec.dynamic.