Fixes crash, take 2 #164
Merged
Fixes crash, take 2 #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ------- tree-sitter-scala crashes under mysterious conditions. gdb seems to indicate that it happens around `get_column`. Solution -------- Avoid calling `get_column` when it's at the end of file. That seems to satisfy fuzz.
|
This get_column at eof hit caused many of the segfaults we saw before in parsers |
ckipp01
approved these changes
Jan 18, 2023
|
Can confirm this actually fixes the issue, thanks again @eed3si9n ! 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159
Problem
tree-sitter-scala crashes under mysterious conditions. gdb seems to indicate that it happens around
get_column.Solution
Avoid calling
get_columnwhen it's at the end of file. That seems to satisfy fuzz.