Skip to content

Abstract type definitions #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2023
Merged

Abstract type definitions #185

merged 1 commit into from
Jan 28, 2023

Conversation

keynmol
Copy link
Collaborator

@keynmol keynmol commented Jan 28, 2023

Closes #182

@keynmol keynmol force-pushed the fix-abstract-type-definitions branch from 3144126 to cb34635 Compare January 28, 2023 08:52
ckipp01
ckipp01 approved these changes Jan 28, 2023
View reviewed changes
Copy link
Collaborator

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 LGTM!

script/smoke_test.sh
@@ -3,7 +3,7 @@
# This is an integration test to generally check the quality of parsing.

SCALA_SCALA_LIBRARY_EXPECTED=100
SCALA_SCALA_COMPILER_EXPECTED=67
SCALA_SCALA_COMPILER_EXPECTED=68
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh yea, 1%.

@ckipp01 ckipp01 merged commit b7cebd2 into tree-sitter:master Jan 28, 2023
@keynmol keynmol deleted the fix-abstract-type-definitions branch January 28, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abstract type definitions
2 participants
@keynmol @ckipp01