Miscallleneous stuff #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxbrunsfeld could you please have a look? (and also to #26) |
grammar.js
Outdated
| @@ -751,6 +755,14 @@ module.exports = grammar({ | |||
| $._automatic_semicolon | |||
| ), | |||
|
|
|||
| null_literal: $ => token('null'), | |||
There was a problem hiding this comment.
I don't think you need the token() call around the string literal.
That function is only needed when you're using other rule-builder functions like seq/repeat/choice, and you want to tell Tree-sitter that the whole rule should be a single token. With a string literal, it's already a single token by default.
Remove redundant token fun call.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few changes to cover small gaps.
Most important is
unitliteral, required forfor-expressioneven in naive implementation.