Skip to content

Added block comments to the comment highlighting query #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

domaspoliakas
Copy link
Contributor

As per a quick conversation on nvim-metals discord channel - block comments didn't get highlighting query added to them when they were split into their own thing, as per @keynmol :

I also found the commit where it slipped through the cracks - the comment node got split but the highlighting query wasn't added: 693c651

This PR rectifies that and adds tests.

Let me know if there's anything else needed here!

/*
* Beep boop
*/
// <- comment
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, was just about to ask but then read the docs:

Arrow: <- this will test the following selector against the scope on the most recent non-test line. It will test it at the same column as the comment character is in.

@susliko
Copy link
Collaborator

susliko commented Jun 6, 2023

I think, these queries should also be added to nvim-treesitter

Copy link
Collaborator

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @domaspoliakas!

@ckipp01 ckipp01 merged commit 2e32a0b into tree-sitter:master Jun 6, 2023
@domaspoliakas domaspoliakas deleted the block-comment-highlighting branch June 6, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants