Issue OUTDENT with extra spaces before brackets #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susliko
force-pushed
the
extra-spaces-before-outdents
branch
2 times, most recently
from
91cca9b to
16974b4
Compare
Problem
-------
```scala
{ x =>
if (a) b.c }
```
is not parsed because OUTDENT token is not emitted in a presense of
space characters before the closing bracket
Solution
-------
Reorder space-handling and outdent-ing logic in external scanner
eed3si9n
approved these changes
Jun 10, 2023
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| # This is an integration test to generally check the quality of parsing. | |||
|
|
|||
| SCALA_SCALA_LIBRARY_EXPECTED=99 | |||
| SCALA_SCALA_LIBRARY_EXPECTED=100 | |||
| @@ -109,6 +109,16 @@ bool tree_sitter_scala_external_scanner_scan(void *payload, TSLexer *lexer, | |||
| int indentation_size = 0; | |||
| LOG("scanner was called at column: %d\n", lexer->get_column(lexer)); | |||
|
|
|||
| while (iswspace(lexer->lookahead)) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
{ x => if (a) b.c }is not parsed because OUTDENT token is not emitted in a presense of space characters before the closing bracket
Solution
Reorder space-handling and outdent-ing logic in external scanner