Add lambda expression and fix call expression #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevanmilic
force-pushed
the
master
branch
2 times, most recently
from
4ada164 to
7eec138
Compare
stumash
reviewed
Sep 3, 2021
stumash
reviewed
Sep 3, 2021
stumash
reviewed
Sep 3, 2021
stumash
reviewed
Sep 3, 2021
stumash
reviewed
Sep 4, 2021
stumash
reviewed
Sep 4, 2021
|
anyway, other than the things I mentioned, LGTM! |
|
@maxbrunsfeld can you take a look at this PR? and also #35? |
stevanmilic
force-pushed
the
master
branch
3 times, most recently
from
0c5b095 to
1564db8
Compare
grammar.js
Outdated
| bindings: $ => seq( | ||
| '(', | ||
| commaSep($.binding), | ||
| ')', |
There was a problem hiding this comment.
Minor nitpick - Could you make the indentation for the new lines consistent with the rest of the file?
grammar.js
Outdated
| ), | ||
|
|
||
| _case_clauses: $ => seq('{', repeat1($.case_clause), '}'), |
There was a problem hiding this comment.
Just curious - what was the purpose of extracting this rule?
There was a problem hiding this comment.
Hmm good catch, it's not needed. I remember adding it because it's used in the call_expression, to dissalow f{}, but that's a valid expression.
Fix call expression to allow block as arguments (tree-sitter#21) Update for comprehension to handle patterns Fix for comprehension to detect assignment as an enumerator Add access modifiers Update trait, object and class parameter to support modifiers Update scanner to support `with` on a new line Update function definition/declaration to support operator naming Update field expression to support operators as methods
|
@maxbrunsfeld I pushed the changes you requested, can we merge this ? |
This was referenced Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix call expression to allow block as arguments (#21)
Update for comprehension to handle patterns
Fix for comprehension to detect assignment as an enumerator
Add access modifiers
Update trait definition to support modifiers
Update function definition/declaration to support operator naming
Update field expression to support operators as methods