Backquoted identifiers #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
reviewed
Jan 3, 2023
grammar.js
Outdated
Comment on lines
782
to
784
| // inside ` corresponds roughly to charNoBackQuoteOrNewline in Scala 3 EBNF | ||
| _char_no_back_quote_or_newline: $=> /[^\n`]+/, | ||
| identifier: $ => choice($._plainid, seq('`', $._char_no_back_quote_or_newline, '`')), |
There was a problem hiding this comment.
If you use seq(...) wouldn't the current grammar allow newline in between the backquote and $._char_no_back_quote_or_newline? i.e.
val `
test-this` = 1There was a problem hiding this comment.
You are right, I changed it from a regex, and it is indeed incorrect.
Using token.immediate also didn't work (and I didn't have the patience to experiment given that the grammar takes 2 minutes at least to regenerate)
It's back to original form in 0d94e6e
keynmol
force-pushed
the
backquoted-identifiers
branch
from
9d6f778 to
dfe6998
Compare
ckipp01
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #51 but I force-pushed the branch on a closed PR and can no longer reopen it.