Smoke test #81
Merged
Smoke test #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this: |
keynmol
reviewed
Jan 5, 2023
|
|
||
| SCALA_SCALA_LIBRARY_EXPECTED=87 | ||
| SCALA_SCALA_COMPILER_EXPECTED=46 | ||
| DOTTY_COMPILER_EXPECTED=35 |
There was a problem hiding this comment.
Only way from here is up. optimistic trombone music
There was a problem hiding this comment.
Merged
keynmol
reviewed
Jan 6, 2023
keynmol
reviewed
Jan 6, 2023
keynmol
reviewed
Jan 6, 2023
This adds real-world integration test using scala/scala and Dotty compiler code base. The expected parse success% is currently hardcoded, but at least we'll catch if this number degrades.
|
I've addressed @keynmol's reviews, so I am going to self-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds real-world integration test using scala/scala and Dotty compiler code base.
The expected parse success% is currently hardcoded, but at least we'll catch if this number degrades.