Skip to content

fix topMovieByRevenue query endpoint sort function #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix topMovieByRevenue query endpoint sort function #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion s2v2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ const resolvers = {
return movies;
},
topMovieByRevenue: (root, args, context) => {
const moviesByRevenueDesc = movies.sort((movieA, movieB) => (movieA.revenue < movieB.revenue));
const moviesByRevenueDesc = movies.sort((movieA, movieB) => (movieB.revenue - movieA.revenue));

return moviesByRevenueDesc[0];
}
Expand Down
2 changes: 1 addition & 1 deletion s2v3.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ const resolvers = {
return movies;
},
topMovieByRevenue: (root, args, context) => {
const moviesByRevenueDesc = movies.sort((movieA, movieB) => (movieA.revenue < movieB.revenue));
const moviesByRevenueDesc = movies.sort((movieA, movieB) => (movieB.revenue - movieA.revenue));

return moviesByRevenueDesc[0];
}
Expand Down
2 changes: 1 addition & 1 deletion s3v2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ const resolvers = {
return movies;
},
topMovieByRevenue: (root, args, context) => {
const moviesByRevenueDesc = movies.sort((movieA, movieB) => (movieA.revenue < movieB.revenue));
const moviesByRevenueDesc = movies.sort((movieA, movieB) => (movieB.revenue - movieA.revenue));

return moviesByRevenueDesc[0];
}
Expand Down
2 changes: 1 addition & 1 deletion s3v3.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ const resolvers = {
return movies;
},
topMovieByRevenue: (root, args, context) => {
const moviesByRevenueDesc = movies.sort((movieA, movieB) => (movieA.revenue < movieB.revenue));
const moviesByRevenueDesc = movies.sort((movieA, movieB) => (movieB.revenue - movieA.revenue));

return moviesByRevenueDesc[0];
}
Expand Down
2 changes: 1 addition & 1 deletion s4v1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ const resolvers = {
return movies;
},
topMovieByRevenue: (root, args, context) => {
const moviesByRevenueDesc = movies.sort((movieA, movieB) => (movieA.revenue < movieB.revenue));
const moviesByRevenueDesc = movies.sort((movieA, movieB) => (movieB.revenue - movieA.revenue));

return moviesByRevenueDesc[0];
},
Expand Down
2 changes: 1 addition & 1 deletion s4v2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ const resolvers = {
return movies;
},
topMovieByRevenue: (root, args, context) => {
const moviesByRevenueDesc = movies.sort((movieA, movieB) => (movieA.revenue < movieB.revenue));
const moviesByRevenueDesc = movies.sort((movieA, movieB) => (movieB.revenue - movieA.revenue));

return moviesByRevenueDesc[0];
},
Expand Down
2 changes: 1 addition & 1 deletion s4v3.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ const resolvers = {
return movies;
},
topMovieByRevenue: (root, args, context) => {
const moviesByRevenueDesc = movies.sort((movieA, movieB) => (movieA.revenue < movieB.revenue));
const moviesByRevenueDesc = movies.sort((movieA, movieB) => (movieB.revenue - movieA.revenue));

return moviesByRevenueDesc[0];
},
Expand Down
2 changes: 1 addition & 1 deletion s4v4.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ const resolvers = {
return movies;
},
topMovieByRevenue: (root, args, context) => {
const moviesByRevenueDesc = movies.sort((movieA, movieB) => (movieA.revenue < movieB.revenue));
const moviesByRevenueDesc = movies.sort((movieA, movieB) => (movieB.revenue - movieA.revenue));

return moviesByRevenueDesc[0];
},
Expand Down