Skip to content
This repository was archived by the owner on Nov 5, 2024. It is now read-only.

build(deps): bump go.opentelemetry.io/otel/sdk/metric from 0.24.0 to 0.25.0 #263

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 13, 2021

Bumps go.opentelemetry.io/otel/sdk/metric from 0.24.0 to 0.25.0.

Changelog

Sourced from go.opentelemetry.io/otel/sdk/metric's changelog.

Changelog

All notable changes to this project will be documented in this file.

The format is based on Keep a Changelog.

This project adheres to Semantic Versioning.

[Unreleased]

[1.2.0] - 2021-11-12

Changed

  • Metric SDK export.ExportKind, export.ExportKindSelector types have been renamed to aggregation.Temporality and aggregation.TemporalitySelector respectively to keep in line with current specification and protocol along with built-in selectors (e.g., aggregation.CumulativeTemporalitySelector, ...). (#2274)
  • The Metric Exporter interface now requires a TemporalitySelector method instead of an ExportKindSelector. (#2274)
  • Metrics API cleanup. The metric/sdkapi package has been created to relocate the API-to-SDK interface:
    • The following interface types simply moved from metric to metric/sdkapi: Descriptor, MeterImpl, InstrumentImpl, SyncImpl, BoundSyncImpl, AsyncImpl, AsyncRunner, AsyncSingleRunner, and AsyncBatchRunner
    • The following struct types moved and are replaced with type aliases, since they are exposed to the user: Observation, Measurement.
    • The No-op implementations of sync and async instruments are no longer exported, new functions sdkapi.NewNoopAsyncInstrument() and sdkapi.NewNoopSyncInstrument() are provided instead. (#2271)
  • Update the SDK BatchSpanProcessor to export all queued spans when ForceFlush is called. (#2080, #2335)

Added

  • Add the "go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc".WithGRPCConn option so the exporter can reuse an existing gRPC connection. (#2002)
  • Added a new schema module to help parse Schema Files in OTEP 0152 format. (#2267)
  • Added a new MapCarrier to the go.opentelemetry.io/otel/propagation package to hold propagated coss-cutting concerns as a map[string]string held in memory. (#2334)

[1.1.0] - 2021-10-27

Added

  • Add the "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc".WithGRPCConn option so the exporter can reuse an existing gRPC connection. (#2002)
  • Add the go.opentelemetry.io/otel/semconv/v1.7.0 package. The package contains semantic conventions from the v1.7.0 version of the OpenTelemetry specification. (#2320)
  • Add the go.opentelemetry.io/otel/semconv/v1.6.1 package. The package contains semantic conventions from the v1.6.1 version of the OpenTelemetry specification. (#2321)
  • Add the go.opentelemetry.io/otel/semconv/v1.5.0 package. The package contains semantic conventions from the v1.5.0 version of the OpenTelemetry specification. (#2322)
    • When upgrading from the semconv/v1.4.0 package note the following name changes:
      • K8SReplicasetUIDKey -> K8SReplicaSetUIDKey
      • K8SReplicasetNameKey -> K8SReplicaSetNameKey
      • K8SStatefulsetUIDKey -> K8SStatefulSetUIDKey
      • k8SStatefulsetNameKey -> K8SStatefulSetNameKey
      • K8SDaemonsetUIDKey -> K8SDaemonSetUIDKey
      • K8SDaemonsetNameKey -> K8SDaemonSetNameKey

Changed

  • Links added to a span will be dropped by the SDK if they contain an invalid span context (#2275).

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [go.opentelemetry.io/otel/sdk/metric](https://github.com/open-telemetry/opentelemetry-go) from 0.24.0 to 0.25.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@metric/v0.24.0...metric/v0.25.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel/sdk/metric
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 13, 2021
@antoineco
Copy link
Contributor

The code doesn't compile and the errors are visible at the bottom of the Files changed tab.

The solution is in the changelog shared by the bot in the PR description:

Metrics API cleanup. The metric/sdkapi package has been created to relocate the API-to-SDK interface:

  • The following interface types simply moved from metric to metric/sdkapi: Descriptor, MeterImpl, InstrumentImpl, SyncImpl, BoundSyncImpl, AsyncImpl, AsyncRunner, AsyncSingleRunner, and AsyncBatchRunner

@antoineco antoineco force-pushed the dependabot/go_modules/go.opentelemetry.io/otel/sdk/metric-0.25.0 branch from fc8fe34 to 79c6fc2 Compare November 13, 2021 11:14
@antoineco
Copy link
Contributor

I made the changes but now the build fails because our version of go.opentelemetry.io/contrib/exporters/metric/cortex is incompatible:

# go.opentelemetry.io/contrib/exporters/metric/cortex
../go/pkg/mod/go.opentelemetry.io/contrib/exporters/metric/[email protected]/cortex.go:57:35: undefined: "go.opentelemetry.io/otel/metric".Descriptor
../go/pkg/mod/go.opentelemetry.io/contrib/exporters/metric/[email protected]/cortex.go:57:75: undefined: "go.opentelemetry.io/otel/sdk/export/metric".ExportKind
../go/pkg/mod/go.opentelemetry.io/contrib/exporters/metric/[email protected]/cortex.go:58:9: undefined: "go.opentelemetry.io/otel/sdk/export/metric".CumulativeExportKind
../go/pkg/mod/go.opentelemetry.io/contrib/exporters/metric/[email protected]/cortex.go:108:39: cannot use exporter (type *Exporter) as type aggregation.TemporalitySelector in argument to "go.opentelemetry.io/otel/sdk/metric/processor/basic".NewFactory:
	*Exporter does not implement aggregation.TemporalitySelector (missing TemporalityFor method)
../go/pkg/mod/go.opentelemetry.io/contrib/exporters/metric/[email protected]/cortex.go:113:42: cannot use exporter (type *Exporter) as type "go.opentelemetry.io/otel/sdk/export/metric".Exporter in argument to "go.opentelemetry.io/otel/sdk/metric/controller/basic".WithExporter:
	*Exporter does not implement "go.opentelemetry.io/otel/sdk/export/metric".Exporter (missing TemporalityFor method)
../go/pkg/mod/go.opentelemetry.io/contrib/exporters/metric/[email protected]/cortex.go:138:24: cannot use e (type *Exporter) as type aggregation.TemporalitySelector in argument to reader.ForEach:
	*Exporter does not implement aggregation.TemporalitySelector (missing TemporalityFor method)

Unfortunately we can't update go.opentelemetry.io/contrib/exporters/metric/cortex right now due to its transitive dependency on Kubernetes 1.22. See #234

@antoineco
Copy link
Contributor

Update

Knative may update its k8s.io dependencies soon: knative/pkg#2327
It's not a clear yes or no yet, so I'm leaving this open for now.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 13, 2021

A newer version of go.opentelemetry.io/otel/sdk/metric exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@antoineco
Copy link
Contributor

Doesn't seem like Knative will get updated anytime soon, so I'm going to close this for now.

@antoineco antoineco closed this Dec 15, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 15, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant