make variable expansion in repl arguments #1381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `repl_ghci_args` attribute to `haskell_library|binary|test` is already forwarded to `haskell_repl` internally. Duplicating the attribute on the `haskell_repl` invocation is redundant and duplicates arguments.
The expansion requires the target's rule `ctx`, so we perform expansion at the target and track the expanded flags in the `HaskellInfo` provider to make it available to `haskell_repl`. `user_compiler_flags` is distinct from `compiler_flags` in that the former holds only flags explicitly provided by the user while the latter includes flags that are generated by rules_haskell.
Perform make variable expansion on the `repl_ghci_args` attribute to `haskell_repl` directly. Add a `data` attribute to `haskell_repl` to enable location references to data files in `repl_ghci_args`.
aherrmann
force-pushed
the
repl-make-variables
branch
from
05a5b36 to
9311fa1
Compare
Profpatsch
approved these changes
Jul 1, 2020
aherrmann
added a commit
that referenced
this pull request
Jul 2, 2020
#1381 added a dedicated `data` attribute to `haskell_repl` which needs to be tracked correctly when data runfiles are constructed explicitly.
aherrmann
added a commit
that referenced
this pull request
Jul 2, 2020
#1381 added a dedicated `data` attribute to `haskell_repl` which needs to be tracked correctly when data runfiles are constructed explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1377
repl_ghci_argsto the autogenerated@repltargets tohaskell_binary|library|test. Theserepl_ghci_argsare already forwarded to the REPL internally.compiler_flagsandrepl_ghci_argsare forwarded to the REPL with make variables expanded.To that end we add
user_compiler_flagsandrepl_ghci_argsfields to theHaskellInfoprovider which carried the expanded values.repl_ghci_argsattribute tohaskell_repldirectly for consistency. To that end, add adataattribute tohaskell_replto enable location references.