Skip to content

Add paragraph on VFC deprecation #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Add paragraph on VFC deprecation #499

merged 3 commits into from
Apr 19, 2022

Conversation

maurer2
Copy link
Contributor

@maurer2 maurer2 commented Apr 14, 2022

Thanks for contributing!

  • If you are making a significant PR, please make sure there is an open issue first
  • If you're just fixing typos or adding small notes, a brief explanation of why you'd like to add it would be nice :)

If you are contributing to README.md, DON'T. README.md is auto-generated. Please just make edits to the source inside of /docs/basic. Sorry, we get that it is a slight pain.

@maurer2
Copy link
Contributor Author

maurer2 commented Apr 14, 2022

Hello, I think it would be a good idea to add a brief note on VFC in React 18, as it recently got deprecated (DefinitelyTyped/DefinitelyTyped#59882).

Cheers

@maurer2 maurer2 changed the title Add paragraph about VFC deprecation Add paragraph on VFC deprecation Apr 14, 2022
@swyxio
Copy link
Collaborator

swyxio commented Apr 19, 2022

thanks!

@swyxio swyxio merged commit 4f0906d into typescript-cheatsheets:main Apr 19, 2022
@madrus
Copy link

madrus commented Apr 29, 2022

Good to know about deprecation. Just a side note, maybe a typo. Have read the changed lines in the commit and see this on line 63:

 Please use regular function components or `React.VFC` instead.

Shouldn't it be React.FC here?

@maurer2
Copy link
Contributor Author

maurer2 commented May 1, 2022

Thanks @madrus. I must have missed that somehow. I have created a pr here to replace VFC with FC: #506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants