Feature/popover-container #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

JesmoDev merged 53 commits into v1/contrib from feature/popover-v2

Sep 14, 2023

Contributor

JesmoDev commented Aug 30, 2023

Description

Adds a popover container that is supposed to be used together with the new popover api Popover documentation.

The container handles positioning and communication with uui-button as only native buttons works out of the box with the new API.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

The current popover solution has z-index issues when used in shadow-doms. Using this new popover container fixes that.

Checklist

If my change requires a change to the documentation, I have updated the documentation in this pull request.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.

JesmoDev added 16 commits

August 23, 2023 15:14


          init

86bb08f


          change to use translate

889347e


          package lock

40f7c32


          WIP placement

f458b4f


          placement fix

5ced391


          working clamps

80376be


          if outside screen, close and remove eventlistener

ac2ed77


          add overflow: visisble

192e1bd


          remove test code from component

d3ed616


          update story

af22154


          use padding instead

8ce38e7


          add custom docs

36166a6


          update docs

7ded70c


          add browser support alert

92a78a8


          change story to use uui-button

4560e50


          add hack to make it somewhat work with uui-button

b0fb4bf

JesmoDev requested a review from nielslyngsoe

August 30, 2023 04:56

github-actions bot commented Aug 30, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-561.westeurope.azurestaticapps.net

nielslyngsoe reviewed

View reviewed changes

packages/uui-button/lib/uui-button.element.ts Outdated Show resolved Hide resolved

nielslyngsoe reviewed

View reviewed changes

packages/uui-popover-container/lib/uui-popover-container.element.ts Outdated Show resolved Hide resolved

nielslyngsoe reviewed

View reviewed changes

packages/uui-popover-container/lib/uui-popover-container.element.ts Show resolved Hide resolved

nielslyngsoe reviewed

View reviewed changes

packages/uui-button/lib/uui-button.element.ts Outdated Show resolved Hide resolved

nielslyngsoe reviewed

View reviewed changes

packages/uui-button/lib/uui-button.element.ts Outdated Show resolved Hide resolved

nielslyngsoe reviewed

View reviewed changes

packages/uui-popover-container/lib/uui-popover-container.mdx Show resolved Hide resolved

JesmoDev added 2 commits

August 31, 2023 22:01


          fix story

51ccf8a


          add flipping

a6990d3

github-actions bot commented Aug 31, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-561.westeurope.azurestaticapps.net


          update story

47f2e74

github-actions bot commented Aug 31, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-561.westeurope.azurestaticapps.net


          better naming

be46936

github-actions bot commented Sep 4, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-561.westeurope.azurestaticapps.net

JesmoDev added 2 commits

September 4, 2023 21:11


          add popovertarget mixin

c073cda


          use popovertarget mixin

44bf4c6

github-actions bot commented Sep 4, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-561.westeurope.azurestaticapps.net

JesmoDev requested a review from nielslyngsoe

September 5, 2023 06:56


          export popover-container in uui package

abeabc5

github-actions bot commented Sep 5, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-561.westeurope.azurestaticapps.net


          Merge branch 'v1/contrib' into feature/popover-container

github-actions bot commented Sep 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-561.westeurope.azurestaticapps.net

JesmoDev added 3 commits

September 11, 2023 16:41


          package lock


          fix findAncestorByAttribute so that it also checks shadow-doms

64a8017


          Merge remote-tracking branch 'origin/v1/contrib' into feature/popover…

6a4288d

…-container

JesmoDev force-pushed the feature/popover-v2 branch from 5a42968 to 6a4288d Compare

September 12, 2023 05:10

github-actions bot commented Sep 12, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-561.westeurope.azurestaticapps.net

iOvergaard added 2 commits

September 13, 2023 09:25


          Merge branch 'v1/contrib' into feature/popover-v2

332c953


          update typescript + vite

75200ca

github-actions bot commented Sep 13, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-561.westeurope.azurestaticapps.net


          set base branch

7c9509b

github-actions bot commented Sep 13, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-561.westeurope.azurestaticapps.net

iOvergaard added 3 commits

September 13, 2023 09:44


          set lib to es2020

fb3466f


          fix import path

df42ab9


          set esbuild to 0.17 to prevent upstream errors

f6f7b0a

github-actions bot commented Sep 13, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-561.westeurope.azurestaticapps.net


          add readme to popover-container

71db838

github-actions bot commented Sep 13, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-561.westeurope.azurestaticapps.net

nielslyngsoe approved these changes

View reviewed changes

Member

nielslyngsoe left a comment

Looks good

JesmoDev merged commit beb237a into v1/contrib

JesmoDev deleted the feature/popover-v2 branch

September 14, 2023 00:00

iOvergaard added feature notable labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature notable