Skip to content

Add tab panel component #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Oct 6, 2023

Description

Currently we have <uui-tab-group> and <uui-tab>. However I think we are missing a <uui-tab-panel> component within <uui-tab-group> to easily allow tabs toggling different tab panels.

This it useful for some inline text or content.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bjarnef bjarnef mentioned this pull request Oct 6, 2023
@nielslyngsoe
Copy link
Member

Hi @bjarnef could you please describe the purpose, eventually a screenshot or similar component of other library?

Is this a case in Backoffice? if not, why would it be useful?

That would be nice, thanks

@bjarnef
Copy link
Contributor Author

bjarnef commented Nov 29, 2023

@nielslyngsoe the current tabs only seems to work by loading a new view as update tab content IIRC.
Often there as need to split content under separate tabs and their tab panels.
It could be some help to editors or maybe just a complex property editor grouping the content/settings under tabs to avoid taking up too much screen real estate.

E.g. something like this: https://shoelace.style/components/tab-panel

And where it isn't necessary to route to other views.
https://www.digitala11y.com/tabpanel-role/

@nielslyngsoe
Copy link
Member

@bjarnef We do have this case a few minor places, but it has just solved with a simple click handler and a Lit-state so its fairly simple to do on your own.

That compared to the amount of coded needed for this solution. And the fact that this logic then is baked into these components is not the type of complexity I would like us to introduce. Its not very transparent and it makes it harder for us to maintain this code going forward. We in general try to draw the line of UI Library, to just bring the UI Components but not the logic for the integrations between these. So the visual bricks but not the glue.

Thanks for your suggestion

@bjarnef
Copy link
Contributor Author

bjarnef commented Jan 23, 2024

@nielslyngsoe it is not just about the visual part, but also from accessibility point of view, where it connects the tab with the panel.

Having this as a component ensures developers doesn't need to handle this on their own ensures consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants