-
Notifications
You must be signed in to change notification settings - Fork 53
Add tab panel component #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
…to feature/tab-panel # Conflicts: # packages/uui-tabs/lib/uui-tab.element.ts
Hi @bjarnef could you please describe the purpose, eventually a screenshot or similar component of other library? Is this a case in Backoffice? if not, why would it be useful? That would be nice, thanks |
@nielslyngsoe the current tabs only seems to work by loading a new view as update tab content IIRC. E.g. something like this: https://shoelace.style/components/tab-panel And where it isn't necessary to route to other views. |
@bjarnef We do have this case a few minor places, but it has just solved with a simple click handler and a Lit-state so its fairly simple to do on your own. That compared to the amount of coded needed for this solution. And the fact that this logic then is baked into these components is not the type of complexity I would like us to introduce. Its not very transparent and it makes it harder for us to maintain this code going forward. We in general try to draw the line of UI Library, to just bring the UI Components but not the logic for the integrations between these. So the visual bricks but not the glue. Thanks for your suggestion |
@nielslyngsoe it is not just about the visual part, but also from accessibility point of view, where it connects the tab with the panel. Having this as a component ensures developers doesn't need to handle this on their own ensures consistency. |
Description
Currently we have
<uui-tab-group>
and<uui-tab>
. However I think we are missing a<uui-tab-panel>
component within<uui-tab-group>
to easily allow tabs toggling different tab panels.This it useful for some inline text or content.
Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist