Skip to content

[Core] Use platform-agnostic device control for DP engine core #17245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jianzs
Copy link
Contributor

@jianzs jianzs commented Apr 27, 2025

Refactor the DP engine core to use the platform-specific device_control_env_var attribute instead of hardcoding CUDA_VISIBLE_DEVICES. This change improves platform compatibility and code maintainability.

The update includes:

  1. Moving the device_id_to_physical_device_id function to a shared utils file
  2. Updating imports in CUDA and ROCm platform files
  3. Replacing CUDA-specific environment variable setting with a platform-agnostic approach in the DPEngineCoreProc class

This refactoring enhances the flexibility of the codebase to support different platforms more seamlessly.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Apr 27, 2025
@jianzs jianzs force-pushed the fix/dev_ctr_env_var branch 4 times, most recently from 434e8bf to 5192d6d Compare April 27, 2025 06:59
Refactor the DP engine core to use the platform-specific `device_control_env_var` attribute instead of hardcoding CUDA_VISIBLE_DEVICES. This change improves platform compatibility and code maintainability.

The update includes:
1. Moving the `device_id_to_physical_device_id` function to a shared utils file
2. Updating imports in CUDA and ROCm platform files
3. Replacing CUDA-specific environment variable setting with a platform-agnostic approach in the DPEngineCoreProc class

This refactoring enhances the flexibility of the codebase to support different platforms more seamlessly.

Signed-off-by: Jade Zheng <[email protected]>
@jianzs jianzs force-pushed the fix/dev_ctr_env_var branch from 5192d6d to ff8b22e Compare April 27, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant