Skip to content

If HOST is provided through environment, friendly notification won't display the actual one #1101

Closed
@tomsseisums

Description

@tomsseisums

There is this:

messages: [`Your application is running here: http://${config.dev.host}:${port}`],

If host is provided through environment, this won't get updated and will still display the value found in config, not taking in mind that it could be changed here:

host: process.env.HOST || config.dev.host,

It's a simple fix, though:

messages: [`Your application is running here: http://${devWebpackConfig.devServer.host}:${port}`]

I won't bother with expected/actual behaviour, because the code lines should be simple to follow.


Posted in response to #1099 (comment), because if the switch was made to use internal portfinder of webpack-dev-server this message will most definitely need a check-up.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions