Skip to content

chore(sfc-playground): adjust the tooltip text for toggling the theme #12116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

w2xi
Copy link
Contributor

@w2xi w2xi commented Oct 6, 2024

Before:

It always shows the text "Toggle dark mode" when hovering over the theme icon.

After:

It will show "Switch to light theme" if the theme is dark; otherwise, it shows "Switch to dark theme".

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🧹 p1-chore Priority 1: this doesn't change code behavior. scope: playground labels Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB 38.1 kB 34.2 kB
vue.global.prod.js 160 kB 58 kB 51.5 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.1 kB 18.9 kB 17.3 kB
createApp 55.7 kB 21.4 kB 19.6 kB
createSSRApp 59.7 kB 23.1 kB 21 kB
defineCustomElement 60.4 kB 23 kB 20.9 kB
overall 69.4 kB 26.5 kB 24.1 kB

Copy link

pkg-pr-new bot commented Oct 7, 2024

Open in Stackblitz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12116

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12116

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12116

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12116

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12116

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12116

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12116

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12116

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12116

vue

pnpm add https://pkg.pr.new/vue@12116

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12116

commit: 59a9167

@yyx990803 yyx990803 merged commit e0a591e into vuejs:main Oct 11, 2024
13 checks passed
abdullah-wn pushed a commit to Lazy-work/vue that referenced this pull request Jan 4, 2025
…vuejs#12116)

* chore(sfc-playground): adjust the tooltip text for toggling the theme

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. ready to merge The PR is ready to be merged. scope: playground
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants