build(server-renderer): Add ESM as a build target #4209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes:
Add ESM as a build target for
@vue/server-renderer
Reasoning:
I'm trying to fix Vue compatibility with Astro, which is build on top of Snowpack, so build tool that doesn't like non-ESM sources, and that causes issues with code duplication and breaking solutions based on being singletons, like
currentRenderingInstance
, that leads to errors while trying to render nested components.Exposing this package as ESM is probably the simplest way to solve that problem, and from what I see some changes in this area was already made, for example ee4cbae, so hope it's inline with the vision.