Skip to content

fix(ssr): properly resolve suspense in teleport #9431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 45 additions & 1 deletion packages/server-renderer/__tests__/ssrTeleport.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Teleport, createApp, h } from 'vue'
import { Teleport, createApp, defineAsyncComponent, h } from 'vue'
import { renderToString } from '../src/renderToString'
import { renderToSimpleStream } from '../src/renderToStream'
import type { SSRContext } from '../src/render'
Expand Down Expand Up @@ -172,4 +172,48 @@ describe('ssrRenderTeleport', () => {
`<div>content</div><!--teleport anchor-->`,
)
})

test('teleport work w/ suspense', async () => {
const ctx: SSRContext = {}

const AsyncComp = defineAsyncComponent(() =>
Promise.resolve({
render: () => h('div', 'content'),
}),
)

const Comp = {
template:
'<teleport to="#target"><Suspense><AsyncComp></AsyncComp></Suspense></teleport>',
components: { AsyncComp },
setup() {},
}
let html = ''
let resolve: any
const p = new Promise(r => (resolve = r))
renderToSimpleStream(
h({
template: '<Comp />',
components: { Comp },
}),
ctx,
{
push(chunk) {
if (chunk === null) {
resolve()
} else {
html += chunk
}
},
destroy(err) {
throw err
},
},
)
await p
expect(html).toBe('<!--teleport start--><!--teleport end-->')
expect(ctx.teleports!['#target']).toBe(
`<div>content</div><!--teleport anchor-->`,
)
})
})
2 changes: 1 addition & 1 deletion packages/server-renderer/src/renderToString.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export async function resolveTeleports(context: SSRContext) {
// note: it's OK to await sequentially here because the Promises were
// created eagerly in parallel.
context.teleports[key] = await unrollBuffer(
await Promise.all([context.__teleportBuffers[key]]),
await Promise.all(context.__teleportBuffers[key].flat()),
)
}
}
Expand Down