Skip to content

Fixed Grammatical Errors in Community Theme Descriptions #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2021
Merged

Fixed Grammatical Errors in Community Theme Descriptions #1376

merged 2 commits into from
Dec 13, 2021

Conversation

seafoamteal
Copy link

Description of Problem

The descriptions of the community theme providers contained a few grammatical errors, namely:

PrimeVue

  1. "look&feel" is incorrect since there should be spaces between the ampersand and the words.

Flatlogic

  1. "Check the admin dashboards templates" does not use the conventional expression "check out". It also unnecessarily pluralises the word "dashboard."
  2. "how real applications is built" has an inconsistency in that the noun "applications" is plural but the verb "is" is singular.
  3. "Additionally these" should have a comma after the preposition "Additionally."

Proposed Solution

PrimeVue

  1. "look & feel"

Flatlogic

  1. "Check out the admin dashboard templates"
  2. "how real applications are built"
  3. "Additionally, these"

Additional Information

@seafoamteal
Fixed grammatical error in theme-data.js
fe4bddc 
In the Flatlogic description, the phrase "how real applications is built" is grammatically incorrect since "applications" is a plural noun but "is" refers to a singular noun. I changed it to "how real applications are built."

In the PrimeVue description, the phrase "look&feel" (which lacked spaces between the words and punctuation) has been changed to "look & feel".
@seafoamteal
Update theme-data.js
031c2c8 
In the Flatlogic description, "Check the admin dashboard templates" has been changed to "Check out the admin dashboard templates."
skirtles-code
skirtles-code approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good!

@skirtles-code skirtles-code merged commit 8533189 into vuejs:master Dec 13, 2021
@skirtles-code skirtles-code mentioned this pull request Feb 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirtles-code skirtles-code skirtles-code approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seafoamteal @skirtles-code