added options for events that ignore custom-event-name-casing #1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devTeaa
force-pushed
the
custom-event-name-options
branch
from
d514178 to
f7b8341
Compare
ota-meshi
requested changes
Oct 8, 2020
There was a problem hiding this comment.
Thank you for this PR!
Perhaps this PR solves #1260 (comment).
Could you add test cases to check ignores input:update, search:update and click:row?
Could you also add description of the new option to the documentation?
https://github.com/vuejs/eslint-plugin-vue/blob/master/docs/rules/custom-event-name-casing.md
devTeaa
force-pushed
the
custom-event-name-options
branch
from
7bb267e to
36603a6
Compare
|
Updated the docs
|
devTeaa
force-pushed
the
custom-event-name-options
branch
from
36603a6 to
ff2f95d
Compare
ota-meshi
requested changes
Oct 9, 2020
Co-authored-by: Yosuke Ota <[email protected]>
Co-authored-by: Yosuke Ota <[email protected]>
|
Added an example for
|
ota-meshi
reviewed
Oct 9, 2020
devTeaa
force-pushed
the
custom-event-name-options
branch
from
fba56c2 to
750e23f
Compare
ota-meshi
approved these changes
Oct 9, 2020
|
Thanks for helping the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, currently there are some components from library that still uses pascalCase when passing the function
<customComponent @maskClick="handleMaskClick"/>this changes added options so it can ignore some event naming just like incomponent-name-in-template-casing.What do you think?