Skip to content

Fix small mistake in require-valid-default-prop #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2017
Merged

Fix small mistake in require-valid-default-prop #143

merged 2 commits into from
Aug 9, 2017

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Aug 9, 2017

  • Improve coverage for FunctionExpression and ArrowFunctionExpression
  • Fix traversing over many types (return -> continue)

armano2 added 2 commits August 9, 2017 14:42
@armano2
Fix small mistakes in require-valid-default-prop
9a039cc 
- Improve coverage for FunctionExpression and ArrowFunctionExpression
- Fix traversing over many types (return -> continue)
@armano2
Cleanup code
52ae435
@armano2
Copy link
Contributor Author

armano2 commented Aug 9, 2017 •
edited
Loading

@michalsnik i tested this rule in few big projects and i found few mistakes what i made there,

  • If there is more than one prop, traversing over props is stopped if type is valid
  • Function and variables are throwing errors

also i added one more test to improve converge

@michalsnik michalsnik merged commit 164b2ae into vuejs:master Aug 9, 2017
@michalsnik
Copy link
Member

N1, good catch :)

@armano2 armano2 deleted the require-valid-default-prop-fix branch August 9, 2017 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsnik michalsnik michalsnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @michalsnik