Skip to content

Add vue/component-options-name-casing rule #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 30, 2021
Merged

Add vue/component-options-name-casing rule #1725

merged 8 commits into from
Nov 30, 2021

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Nov 23, 2021

Close #1723 .

FloEdelmann
FloEdelmann requested changes Nov 23, 2021
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all, this looks very good! Also very extensive test cases 👍

I have just two minor code style suggestions and one mistake in the docs.

ota-meshi
ota-meshi requested changes Nov 24, 2021
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!
Almost good, but I have two change requests for auto-fix.

@g-plane g-plane marked this pull request as draft November 24, 2021 06:22
@g-plane g-plane marked this pull request as ready for review November 24, 2021 07:15
ota-meshi
ota-meshi approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

FloEdelmann
FloEdelmann requested changes Nov 24, 2021
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just very minor stuff missing. Thanks for your quick improvements!

@ota-meshi ota-meshi merged commit 10dd1a9 into vuejs:master Nov 30, 2021
@g-plane g-plane deleted the component-options-name-casing branch November 30, 2021 06:04
@lsdsjy lsdsjy mentioned this pull request Sep 26, 2022
Closed
4 tasks
@FloEdelmann FloEdelmann linked an issue Sep 26, 2022 that may be closed by this pull request
Rule Change Proposal: component-name-in-template-casing #854
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New rule: component-options-name-casing Rule Change Proposal: component-name-in-template-casing
3 participants
@g-plane @FloEdelmann @ota-meshi