Skip to content

Fix #1808: Lint slots in attribute-hyphenation #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2022

Conversation

doug-wade
Copy link
Contributor

Fixes #1808

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
I have just one suggestion.

@FloEdelmann FloEdelmann requested a review from ota-meshi March 24, 2022 11:21
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doug-wade doug-wade requested a review from ota-meshi March 27, 2022 05:08
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit f59de96 into vuejs:master Apr 4, 2022
@doug-wade
Copy link
Contributor Author

@ota-meshi @FloEdelmann Thanks so much for your thorough reviews and quick response time! It's been a great experience to add some features I need!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue/attribute-hyphenation doesn't work on <slot> element
3 participants