Skip to content

Upgrade babel-eslint #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2018
Merged

Upgrade babel-eslint #438

merged 1 commit into from
Mar 22, 2018

Conversation

michalsnik
Copy link
Member

@michalsnik michalsnik commented Mar 21, 2018 •
edited
Loading

☝️

@michalsnik michalsnik requested a review from mysticatea March 21, 2018 06:13
@mysticatea
Copy link
Member

Sorry, I have been inactive in OSS since March 5 because of my sick.

I think this is not necessary since devDependencies is not related to userland (though maybe needs to clear cache from CircleCI).
If a user is using babel-eslint, they need to update own package.json for new babel-eslint.

@michalsnik michalsnik changed the title Fixes #349 - Upgrade babel-eslint Upgrade babel-eslint Mar 22, 2018
@michalsnik
Copy link
Member Author

Yeah, I just realised it's devDependency 🤦‍♂️ but it won't hurt to update it anyway :)

mysticatea
mysticatea approved these changes Mar 22, 2018
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@michalsnik michalsnik merged commit bc65718 into master Mar 22, 2018
@michalsnik michalsnik deleted the update-babel-eslint branch March 22, 2018 03:51
This was referenced Mar 22, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

Assignees
No one assigned
Labels
semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalsnik @mysticatea