Skip to content

Fix: Allow props with validator without type in vue/require-prop-types #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Jul 18, 2018
Merged

Fix: Allow props with validator without type in vue/require-prop-types #476

merged 2 commits into from Jul 18, 2018

Conversation

ghost
Copy link

@ghost ghost commented May 17, 2018

According to the docs, if the type property is insufficient and more complex type-checking is required, one can use the validator property. Currently eslint-plugin-vue reports an error in such cases.

Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thans @st-sloth !

@ghost
Copy link
Author

ghost commented Jul 15, 2018

Done! Updated docs and rebased on master.

Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 👍

@michalsnik michalsnik merged commit 23fa9d4 into vuejs:master Jul 18, 2018
@ghost ghost deleted the fix-require-prop-types-with-validator branch February 16, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant