Skip to content

Adding default array example of correct rule #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2018
Merged

Adding default array example of correct rule #573

merged 3 commits into from
Sep 28, 2018

Conversation

guillaumebriday
Copy link
Contributor

No description provided.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guillaumebriday Thank you for this PR!
I have one request.

@@ -42,6 +42,10 @@ props: {
// multiple possible types
propB: [String, Number],
// a number with default value
propC: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is described in the comment of propE as follows,
// object/array defaults should be returned from a factory function
If you add an example near propE, I think that it is easy to understand.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep you're right, I'll make the change !

Also, I think we coud update the propE to use the arrow function ? What do you think about it ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guillaumebriday Thank you for your suggestion.
I have looked at other documents.

Many seemed to prefer the shorthand method.
(for example here)
Could you write it in shorthand default () {}?

@michalsnik
Copy link
Member

Thank you @guillaumebriday 👍 I updated defaults using function shorthand, instead of arrow function. It is a bit more sensible way to write these defaults, methods and any other thing in Vue, as you won't get into trouble when this is wrong when you need to use it inside the function. This way you're prepared for it.

@michalsnik michalsnik merged commit ce7cb10 into vuejs:master Sep 28, 2018
@guillaumebriday
Copy link
Contributor Author

Hey @michalsnik sorry I could not check it out before.

Thanks for the update and the merge ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants