Skip to content

chore: Fix typo in comments #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2018
Merged

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 25, 2018

No description provided.

@michalsnik
Copy link
Member

Since we're still in beta v5 I'm going to revert PR with match-component-file-name (cc @ota-meshi), and merge it once we complete docs and release V5 officially - let's not merge any more rules until then. Could you then leave only typo fixes in this PR @armano2 ?

@armano2 armano2 changed the title chore: Add missing type to match-component-file-name and fix typos in comments @armano2 chore: Fix typo in comments Nov 25, 2018
@armano2 armano2 changed the title @armano2 chore: Fix typo in comments chore: Fix typo in comments Nov 25, 2018
@armano2
Copy link
Contributor Author

armano2 commented Nov 25, 2018

@michalsnik done

@@ -6,7 +6,7 @@
const utils = require('../utils')

// ------------------------------------------------------------------------------
// Rule Definitionutilu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whaat happened here 🙈 😂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no clue but editor was screaming at me on this file xd

Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches

@michalsnik michalsnik merged commit 61a667f into vuejs:master Nov 25, 2018
@armano2 armano2 deleted the missing-type branch November 25, 2018 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants