Skip to content

Fix no async with empty returns #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Conversation

dougalg
Copy link
Contributor

@dougalg dougalg commented Feb 14, 2019

no-async-in-computed-properties errors out when there is no return value in a function.

@mysticatea
Copy link
Member

Thank you for the PR!

@mysticatea mysticatea added the bug label Feb 14, 2019
@mysticatea mysticatea merged commit 7e4936f into vuejs:master Feb 14, 2019
@dougalg dougalg deleted the fix-no-async branch February 14, 2019 09:09
@dougalg
Copy link
Contributor Author

dougalg commented Feb 14, 2019

My pleasure, thank you for the project :)

@axit-joost
Copy link

Heh, I just opened issue #817, only to find this merge request like 5 seconds later :-) 👍

Next time I'll check here first 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants