Bug in select2 wrapper component example (on options changed) #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I just forked your fork, as we like to keep the fiddles under member accounts for security reasons. 🙂 |
kazupon
pushed a commit
to kazupon/vuejs.org
that referenced
this pull request
Oct 1, 2017
…1144) (vuejs#349) * tweak ad styling * Bug in select2 wrapper component example (on options changed) (vuejs#1144) * Update select2.md * Update multiselect example of fiddle
|
This approach ends up throwing out any additional options that are passed in via the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found when using this - if the options change after rendering, the new set gets appended to the existing set rather than replacing them. Adding the empty() call in the options watch solved this.
I'm not sure how to update the jsfiddle so I linked to my fork of it, happy to change as needed!