Style guide: Update abbreviation rule to note avoidance #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikestreety
changed the title
|
The rule titles only include the topic, rather than the specific suggestion. 🙂 |
|
Ah ok, thanks @chrisvfritz - I did get a little confused as it says:
Took me a while to work it out! Is this something I could raise as an issue? Great style guide by the way, massive help! |
|
Ah, I can definitely see how that could be confusing! 🙂 Thanks for the further explanation. Maybe we should update it to:
What do you think? |
|
Works for me! 👍 updated! |
|
Thanks! 🎉 |
kazupon
pushed a commit
to kazupon/vuejs.org
that referenced
this pull request
Nov 24, 2017
…uejs#379) * Update abbreviation rule to note avoidance * Style guide: Switch abbreviation title with correct tense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.